FIO-8645: day component required validation error not correct #5687
Conversation
There was a problem hiding this comment.
In @formio/core/src/process/validation/rules there is a file called validateRequiredDay.ts. This seems to be added in because you can set the required validation check on the day, month, and year inputs individually. Right now we have three translation keys for the day component and that is requiredDayField, requiredMonthField, and requiredYearField. I can either ...
- change requiredDayField, requiredMonthField, and requiredYearField to just required
- delete the validateRequiredDay.ts file and pass the responsibility back to some function inside the validateRequired.ts file. This would require a check to see if the component is a day component and some extra validation checking due to the fact that you can set required validations for day, month, and year individually.
I've also just noticed that even if you have required validation on for all of them, the validator will only throw an error for one of them in the order of day, month, and year. So if you have all of them set to required only the day will be marked as a required error
|
Talked to Brenden this morning in dev support, he is ok with having a translation key for the day component required validations for day, month, and year. The "I've also just noticed that even if you have required validation on for all of them, the validator will only throw an error for one of them in the order of day, month, and year. So if you have all of them set to required only the day will be marked as a required error" problem will need another separate ticket to solve it. Changing the type of the validateRequiredDaySync to a function that returns a list of FieldErrors was starting to become challenging for me and required very many changes to the types of RuleFn, RuleFnSync, ValidationRuleInfo, and more. Not only that but changing all these types to support FieldError arrays would require array type checking on variables of type ValidationRuleInfo because you would need to check whether you are dealing with a FieldError or a FieldError[] |
|
Added core tests and translations |
Link to Jira Ticket
https://formio.atlassian.net/browse/FIO-8645
Description
What changed?
Previously, formio.js did not have the requiredDayField translation key in the en.js file which caused the required validation to not display correctly. This PR replaces this behavior by adding requiredDayField translation key to the translation file
Dependencies
N/A
How has this PR been tested?
I added automated tests and manually tested
Checklist: